Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

Phenotypes and Diseases are missing taxon, so are many genes #1448

Open
jmcmurry opened this issue Apr 26, 2017 · 4 comments
Open

Phenotypes and Diseases are missing taxon, so are many genes #1448

jmcmurry opened this issue Apr 26, 2017 · 4 comments

Comments

@jmcmurry
Copy link
Member

jmcmurry commented Apr 26, 2017

Phenotypes and Diseases should have associated taxa. Many genes are also missing taxa. The fact that they do not produces weird search results. I could have sworn that this was already a ticket. It has been mentioned several times in other tickets (eg here), but I'm breaking it out for clarity.

Genes Diseases Phenotypes
Taxon tally is too small No hits in any taxon No hits in any taxon
screen shot 2017-04-26 at 11 46 49 am screen shot 2017-04-26 at 11 46 36 am screen shot 2017-04-26 at 11 46 18 am
@jmcmurry
Copy link
Member Author

jmcmurry commented Apr 26, 2017

For now, I wonder if a stop gap could be that the taxon column disappears if "phenotype" or "disease" facet is selected. @jnguyenx ?

@jnguyenx
Copy link
Contributor

I think that it's expected behavior with the given data. E-commerce websites also have the same pattern if I'm not mistaken.
I wouldn't add hacks to hide the underlying problem, but rather fix the actual data.

One improvement I can see is to make the filters with (0) unclickable.

@jmcmurry
Copy link
Member Author

jmcmurry commented Apr 26, 2017

@cmungall
Copy link
Member

Taxa for diseases: monarch-initiative/monarch-disease-ontology-RETIRED#59

Taxa for phenotypes: what is expected many not be what is logical here. For example, an ontology term 'abnormality of brain' would be subClassOf in-taxon some Eumetazoa.

If we stratify phenotype ontologies into a lattice as described here: obophenotype/upheno#171

We would have HP be only homo, MP only mouse (or rodents), etc, which people would probably find more intuitive.

@kshefchek kshefchek removed their assignment Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants