Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes make commands & docs #17

Merged
merged 2 commits into from
Sep 12, 2022
Merged

fixes make commands & docs #17

merged 2 commits into from
Sep 12, 2022

Conversation

0rphon
Copy link
Contributor

@0rphon 0rphon commented Sep 8, 2022

fixes make commands & docs to not have separate commands for online/offline/mainnet/testnet since thats all controlled via a config file and not the command fed into docker.

also fixes the command used to launch the node so it actually respects mainnet vs testnet modes

this DOES NOT FIX #16 or #18

…ffline/mainnet/testnet since thats all controlled via config
@0rphon 0rphon self-assigned this Sep 8, 2022
@0rphon 0rphon requested a review from gluax September 8, 2022 20:08
Copy link

@gluax gluax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0rphon 0rphon merged commit cd1a9c4 into main Sep 12, 2022
@0rphon 0rphon deleted the documentation-fixes branch September 12, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] make build-local just clones the repo from github
2 participants