Parent & al. #16
Parent & al. #16
Conversation
marcandre
force-pushed
the
parent
branch
2 times, most recently
from
1f9036b to
de6b887
Compare
lib/tlaw/has_parent.rb
Outdated
| result | ||
| end | ||
|
|
||
| def lineage |
There was a problem hiding this comment.
I am not sure about the name, never met this word used in this context :)
Are there any other gems/Ruby project that provide the same API ("me and my parents") you aware of?.. What names do they prefer?
There was a problem hiding this comment.
Well, there's Module#ancestors, which includes the module itself... but we can't use that. It's not really mandatory. I've removed it from the PR, we can add it later if need be.
| grand_child_class | ||
| ] | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
With saharspec (already included) you can make it this way:
subject { ->(*args) { namespace_class.traverse(*args).to_a } }
its_call { is_expected.to ret [...] }
its_call(:namespaces) { is_expected.to ret [...] }
its_call(:endpoints) { is_expected.to ret [...] }
# ...and also..
its_call(:garbage) { is_expected.to raise_error ArgumentError }(ret is matcher name for "(its call) returns")
For me, this is more DRY and expresses "what's going on" better (params difference is not hidden in the middle of example, "what is test subject" also made obvious), but I will not insist, I heard different opinions on those tricks :)
There was a problem hiding this comment.
Oh, nice. Changed.
|
Thanks! And sorry for the delay. |
|
Cool 😸 |
|
Let's finish with all your open PRs discussion, and then we'll do it? |
|
Lol, personally, I make a release for any new feature or bug fix. I figure it costs nothing, and avoids waiting for a PR, then there's another open, etc... and time passes by. |
|
Well, with 3 open PRs on the table I prefer {discuss/merge 3 PRs}→{release} to {merge}→{release}×3. |
|
@zverok here's why I prefer to make frequent releases... It's been a month (since my request) the last release is more than a year old, and there are many differences between the current code and the released code. And there are still 3 open PRs 😈 |
|
(Give me the access and I'll do the releases for you!) |
|
Yeah, you were right, I was wrong (expecting we'll "just finalize it" in 1-2 days). But currently things are tough for me. |
This PR fixes #12 by adding:
parent,parents&lineageas instance and singleton methods toAPIPathNamespace.traverseIt builds on [#15], but doesn't really depend on it.