Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #59

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Dev #59

merged 3 commits into from
Jul 31, 2024

Conversation

paulsaxe
Copy link
Collaborator

@paulsaxe paulsaxe commented Jul 31, 2024

Bugfix and improvements for parallel runs

  • There was an issue saving the pressure and volume as properties due to a mismatch in the names used. This has been corrected.
  • Improved how the code determines the number of processors to use for parallel runs, giving salience to the number of atoms in the system, but limiting to the LAMMPS and global limits on numbers of cores as well as the hardware available.

   
* There was an issue saving the pressure and volume as properties due to a mismatch
  in the names used. This has been corrected.
 * Improved how the code determines the number of processors to use for parallel runs,
   giving salience to the numer of atoms in the system, but limiting to the LAMMPS and
   global limits on numbers of cores as well as the hardware available.
   
* There was an issue saving the pressure and volume as properties due to a mismatch
  in the names used. This has been corrected.
 * Improved how the code determines the number of processors to use for parallel runs,
   giving salience to the numer of atoms in the system, but limiting to the LAMMPS and
   global limits on numbers of cores as well as the hardware available.
@paulsaxe paulsaxe added bug Something isn't working enhancement New feature or request labels Jul 31, 2024
@paulsaxe paulsaxe requested a review from seamm July 31, 2024 16:53
Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seamm seamm merged commit 6e0ca76 into main Jul 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants