-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a script to obtain the status of the simulation #117
base: master
Are you sure you want to change the base?
Conversation
I think in order to make this an integration test, we need to publish a reference to compare against. Can you add the scaffolding to save the results and compare with another file of the same schema? Then we check the reference into version control and monitor change from there. This does not tell us whether the results are numerically identical, which is considered the holy grail in integration tests. |
A quick demonstration on how the script can be used logs.mp4 |
Logs from a successful simulation : |
@radistoubalidis - could you use this script in your CML Action? @Namyalg - if it weren't for the timestamps, we would be able to use the hash of these logs as a reference. Are timestamps included in the console output when you run the simulation inside the container interactively? Or are they part of th Docker output? |
I just added it to my action here , the only issue is a haven't yet managed to run the whole workflow inside actions so for now, I made it use the results from a sim I run locally. |
The timestamp can be removed, I'll process it such that only
Yes, this can be removed, I'll process it in such a way that To identify the simulation uniquely, how about appending the end of the file with a randomly generated string? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to add the python script to my simulation results and retrieve the log file
@Namyalg - can you please remind me if this is ready to merge? Do you have permissions to do so? |
Yes @aornugent, I tested the script again, it works as expected -> retrieve the logs of a container running the simulation |
Pull Request Template
Description
The existing endpoints for the gcbm example do not report a failure in the simulation.
The script
simulation-status.py
returns the logs of the docker container (if it is running).This can be used in the process of automated testing
To obtain the logs of the simulation :
simulation-status.py
, a text file containing the logs will be createdFixes #93
Type of change
Please delete options that are not relevant.