-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: specify msrv #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, if we specify a MSRV we should also have automated tests to check that the crate compiles with that version. WDYT?
@fabian-braun I think this is done automatically. If you specify a lower version, linting will fail on the specific functionality that doesn't work at that version. I think this is possible because the standard lib has every method annotated, e.g. |
@fabian-braun I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I knew that other projects have a MSRV check in CI, so I was surprised that there's a lint for it. Maybe the check is also advisable when you depend on other third-party crates.
With the stabilization of the minimum supported Rust version (MSRV) aware resolver it becomes more relevant to specify the MSRV of
tinytime
. I used cargo-msrv to determine the number. I think that the version number is relatively recent because we use theexpect
annotation which was only stabilized in version 1.81.0.closes #6