Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try catch for JSON parse - GrpcToHttpInterceptor #14

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Try catch for JSON parse - GrpcToHttpInterceptor #14

wants to merge 7 commits into from

Conversation

mirkobertone
Copy link

This resolve this issue: #13

@mirkobertone mirkobertone mentioned this pull request Apr 9, 2024
Open
@mohsenbostan
Copy link
Owner

Nice catch @mirkobertone!
thanks for opening a PR. please undo the changes to the CHANGELOG.md and the package.json. then I can release it.

@mirkobertone
Copy link
Author

Hi @mohsenbostan!
I updated the PR

rajibkuet07 added a commit to rajibkuet07/nestjs-grpc-exceptions that referenced this pull request Jun 7, 2024
@rajibkuet07
fix(interceptor): fix rpc exception message in http to grpc interceptor
5640670 
Handles all sorts of http exceptions from rpc client.
No need to use extra try catch for parse error in grpc to http interceptor.

Refs: mohsenbostan#13
Refs: mohsenbostan#14
@rajibkuet07 rajibkuet07 mentioned this pull request Jun 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohsenbostan mohsenbostan mohsenbostan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirkobertone @mohsenbostan