Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR:#235 Added Payment.jsx & fixed styling issues in cart #256

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

siddheshhr
Copy link
Contributor

@siddheshhr siddheshhr commented Jun 9, 2024

ISSUE:#234 Enhancement+Bug
see #235 created a new pr to fix conflicts
I'm excited to add a significant improvement to the user checkout experience: a streamlined multi-page checkout flow with mock payment functionality. This addresses the previous limitation where checkout and payment details were combined on a single page

1.) Key Enhancements:

Separated Checkout Process: Introduced a "Proceed to Checkout" button, gracefully transitioning users from the cart to a dedicated payment page (Payment.jsx).

Mock Payment Form: Implemented Payment.jsx as a user-friendly form for entering mock payment card details (non-functional validation). Fields include:
Cardholder Name
Card Number (16 digits)
Expiration Date (MM/YY format)
CVV (3-digit code)

Seamless Navigation: Upon form submission in Payment.jsx, the user is directed to a Success.jsx page displaying a confirmation message ("Thank you, your order has been placed!").

-**Styling issue:**Also fixed the styling issue of the select option which was not properly being displayed have fixed the css styling and gave it proper spacing

image

image

image

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shopy-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 7:02pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @siddheshhr! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@siddheshhr
Copy link
Contributor Author

siddheshhr commented Jun 9, 2024

@mohitparmar1 pls check this pr i have resolved the conflict once .old pr #235

@siddheshhr siddheshhr changed the title Added Payment.jsx & fixed styling issues in cart #235 Added Payment.jsx & fixed styling issues in cart Jun 10, 2024
@siddheshhr siddheshhr changed the title #235 Added Payment.jsx & fixed styling issues in cart PR:#235 Added Payment.jsx & fixed styling issues in cart Jun 10, 2024
@siddheshhr
Copy link
Contributor Author

@mohitparmar1 as requested by you i have made a seprate pr to resolve the conflicts pls merge this pr dont want to again resolve conflicts if possible

@mohitparmar1 mohitparmar1 merged commit 953dc39 into mohitparmar1:main Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants