Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#82: Google Authentication, Login and Signup backend #241

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

SaurabhS55
Copy link
Contributor

Hey @mohitparmar1, I have added new feature called login with google. While working on this feature, I have noticed that login and signup backend is not developed yet. To work on google auth, it was neccessary to develop basic login and signup backend.
so, firstly I developed it and then I implemented this feature.
Features:

  1. Login and Signup backend.
  2. "Login with google" : Used react-oauth/google npm library for google auth.
  3. React toasify toasts: used for better and user friendly UI.

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shopy-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 8:27am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SaurabhS55! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@SaurabhS55
Copy link
Contributor Author

@mohitparmar1, review it once.

Copy link
Collaborator

@anasadh anasadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine.

@mohitparmar1
Copy link
Owner

please resolve conflicts to merge the pr!

@SaurabhS55
Copy link
Contributor Author

please resolve conflicts to merge the pr!

@mohitparmar1 plzz preview the version once, before merging the pr.

@SaurabhS55
Copy link
Contributor Author

SaurabhS55 commented Jun 10, 2024

Hey @mohitparmar1 @anasadh @adil-techcode any update on review ?

@mohitparmar1 mohitparmar1 merged commit 63a75ab into mohitparmar1:main Jun 11, 2024
3 checks passed
@SaurabhS55 SaurabhS55 deleted the googleAuth branch June 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants