Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #83 Login and Signup form validation fixed #187

Merged
merged 4 commits into from
May 26, 2024

Conversation

SaurabhS55
Copy link
Contributor

Hey @mohitparmar1, I have fixed login and signup validation issues and also improved its UI.

Before Improvements:
image

After Improvements:
image

Features Added:-

  1. Added checks for password and email validation.
  2. Added show password feature.
  3. Improved UI.

Once this PR got merged, I will work on my another assigned issue of google auth, along with I will also implement backend routes for this forms and ensures that it will work seamlessly.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shopy-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 3:09pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SaurabhS55! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@SaurabhS55
Copy link
Contributor Author

Hey @mohitparmar1 I have made my PR, plz review it once?

@mohitparmar1 mohitparmar1 merged commit 45a180d into mohitparmar1:main May 26, 2024
4 checks passed
@SaurabhS55
Copy link
Contributor Author

Hey @mohitparmar1, Could you change the label from "Level 2" to "level2". I haven't got contribution score for this contribution.

@SaurabhS55 SaurabhS55 deleted the formValidation branch June 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants