perf(plugin): improve error message in Link component

mohatt · Jul 30, 2021 · 0ebdfa5 · 0ebdfa5
1 parent bb91a5a
commit 0ebdfa5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/example/src/templates/about.js b/example/src/templates/about.js
@@ -6,7 +6,7 @@ const AboutTemplate = ({ data: { page } }) => (
   <Layout title={page.title}>
     <div className="row">
       <div className="col-md-3">
-      <img className="card-img" src="http://placehold.it/100x200" alt="" />
+      <img className="card-img" src="//via.placeholder.com/100x200" alt="" />
       </div>
       <div className="col-md-9">
         <div>

diff --git a/src/components/Link.js b/src/components/Link.js
@@ -8,9 +8,10 @@ const Link = ({ to, params, scope, ...props }) => {
     try {
       to = generatePath(to, params, scope, true)
     } catch (e) {
-      console.error(
-        'Warning: Invalid route params supplied to `Link` component: ' + e.message
-      )
+      if (process.env.NODE_ENV !== 'production') {
+        console.error(`gatsby-plugin-advanced-pages: Unable to generate path for route "${to}": ${e.message}`)
+      }
+      to = '/404.html'
     }
   }
 

diff --git a/src/components/__tests__/__snapshots__/Link.js.snap b/src/components/__tests__/__snapshots__/Link.js.snap
@@ -12,15 +12,15 @@ Array [
 exports[`<Link /> should log console error when called with invalid props 2`] = `
 Array [
   Array [
-    "Warning: Invalid route params supplied to \`Link\` component: Error generating a path for route \\"/blog/post/:post\\" with params \\"{}\\": Expected \\"post\\" to be a string",
+    "gatsby-plugin-advanced-pages: Unable to generate path for route \\"blog.post\\": Error generating a path for route \\"/blog/post/:post\\" with params \\"{}\\": Expected \\"post\\" to be a string",
   ],
 ]
 `;
 
 exports[`<Link /> should log console error when called with invalid props 3`] = `
 Array [
   Array [
-    "Warning: Invalid route params supplied to \`Link\` component: Error generating a path for route \\"/blog/post/:post\\" with params \\"{\\"invalid\\":\\"whatever\\"}\\": Expected \\"post\\" to be a string",
+    "gatsby-plugin-advanced-pages: Unable to generate path for route \\"blog.post\\": Error generating a path for route \\"/blog/post/:post\\" with params \\"{\\"invalid\\":\\"whatever\\"}\\": Expected \\"post\\" to be a string",
   ],
 ]
 `;