Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker images #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add docker images #6

wants to merge 4 commits into from
+64 −0

Conversation

anandrkskd
Copy link
Collaborator

No description provided.

mohammedzee1000
mohammedzee1000 reviewed Jan 18, 2021
View reviewed changes
Copy link
Owner

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be prudent to build the cli in the container rather than downloading a release?

@anandrkskd
Copy link
Collaborator Author

understood i will make changes for building binary in the container

@anandrkskd
Copy link
Collaborator Author

@mohammedzee1000 how does having a ci-firewall binary inside a container help us for any case

@mohammedzee1000
Copy link
Owner

For development, I want whatever ci-firewall from code I'm writing, not a released version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 mohammedzee1000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandrkskd @mohammedzee1000