Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request query parameters instead of hash for getting username #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moeenio
Copy link
Owner

@moeenio moeenio commented Feb 9, 2020

Fixes #55.

Phew, that was a hard one 😀.

@moeenio
Copy link
Owner Author

moeenio commented Feb 9, 2020

ping @Andreto

@Andreto
Copy link
Contributor

Andreto commented Feb 9, 2020

Will this delete the old system? Meaning that the previously generated codes won't work. Also when weiving the netlify page it generated codes with hash and not query.

@moeenio
Copy link
Owner Author

moeenio commented Feb 9, 2020

Will this delete the old system?

Nope, I said so in #55, and just look at the code.

it generated codes with hash and not query.

Oh yeah, need to update that, thanks for pointing out :)

@moeenio moeenio self-assigned this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use request query parameters for username
2 participants