Fixing the example xpdo.query #408
Open
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-H
requested changes
Jul 19, 2022
| @@ -37,12 +37,11 @@ The SQL statement to prepare and execute. Data inside the query should be [prope | |||
|
|
|||
| ```php | |||
| $result = $modx->query("SELECT * FROM modx_users WHERE id=1"); | |||
| if (!is_object($result)) { | |||
There was a problem hiding this comment.
I believe $modx->query will return false if the query is somehow invalid, perhaps also if there are issues connecting to the database. So while that shouldn't happen in this particular example, it is important to check the $result is an object. IIRC it's a \PDOStatement object.
| if(!$result->fetch(PDO::FETCH_ASSOC)) { | ||
| return 'No result!'; | ||
| } else { | ||
| $row = $result->fetch(PDO::FETCH_ASSOC); |
There was a problem hiding this comment.
Because this is the second time $result->fetch() is called, if there are multiple results (there wont be in this example) this will return the second rather than the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the example xpdo.query
Affected versions
both
Relevant issues
#391