Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(retry-plugin): remove unnecessary null-check before calling beforeExecuteRetry #3361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haesoo-y
Copy link
Contributor

@haesoo-y haesoo-y commented Dec 15, 2024

chore(retry-plugin): remove unnecessary null-check before calling beforeExecuteRetry

Description

removes the unnecessary null-check before calling beforeExecuteRetry() since a default no-op function is already assigned.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

netlify bot commented Dec 15, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 734dfdc
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/675e863fcefe2d000861d3bd
😎 Deploy Preview https://deploy-preview-3361--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant