Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website-new): add monorepo information to the practice section #3351

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 12, 2024

Description

Add a section to "Practice" area of the module-federation.io site for Monorepos.

Add two new docs:

  • Benefits of Module Federation in a Monorepo
  • Using Nx for Module Federation

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 89c8f81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 89c8f81
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/675d038ad0741600083ec556
😎 Deploy Preview https://deploy-preview-3351--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Coly010 Coly010 requested a review from jaysoo December 12, 2024 20:01
@ScriptedAlchemy
Copy link
Member

@zackarychapple please skim and authorize vendor plugs

You can get all the benefits of Module Federation without the hassle of managing multiple repositories when you choose a monorepo, including some additional benefits around code sharing and dependency management.
This guide will help you understand the benefits of using Module Federation in a monorepo and how they address organizational challenges.

## Flaws with the Polyrepo Approach
Copy link
Collaborator

@zackarychapple zackarychapple Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of flaws we call this "Potential drawbacks of a polyrepo approach" or "potential issues"

Copy link
Collaborator

@zackarychapple zackarychapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor update requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants