Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(enhanced): improve schema validation maintainability #3335

Draft
wants to merge 5 commits into
base: consume-share-layers
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

Description

This pull request includes several changes to the packages/enhanced module, focusing on simplifying the schema definitions and improving validation logic. The most important changes are as follows:

Schema Simplification:

Validation Logic Improvements:

Test Configuration Update:

  • package.json: Modified the enhanced:jest script to run tests on test/schema.basictest.js instead of test/ConfigTestCases.basictest.js.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 68cdcfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from provide-share-layers to consume-share-layers December 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant