refactor(enhanced): improve schema validation maintainability #3335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the
packages/enhanced
module, focusing on simplifying the schema definitions and improving validation logic. The most important changes are as follows:Schema Simplification:
packages/enhanced/src/schemas/container/ContainerPlugin.check.ts
: Removed theanyOf
condition from theruntimePlugin
schema, simplifying the structure by only allowing strings.packages/enhanced/src/schemas/container/ContainerPlugin.ts
: Simplified theruntimePlugin
schema by removing theanyOf
condition and the nested object definition.Validation Logic Improvements:
packages/enhanced/src/schemas/container/ContainerPlugin.check.ts
: Enhanced thevalidate33
function to include additional checks for thecommonjs2
property and improved error handling for various conditions.packages/enhanced/src/schemas/container/ContainerPlugin.check.ts
: Updated error identifiers in thevalidate33
function to ensure consistency and clarity in error reporting.Test Configuration Update:
package.json
: Modified theenhanced:jest
script to run tests ontest/schema.basictest.js
instead oftest/ConfigTestCases.basictest.js
.Related Issue
Types of changes
Checklist