Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runtime): remove duplicate registerRemotes warn #3325

Merged
merged 4 commits into from
Dec 12, 2024
Merged

chore(runtime): remove duplicate registerRemotes warn #3325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
795010a
chore(runtime): remove duplicate registerRemotes warn
2heal1 Dec 6, 2024
2e63de7
Merge branch 'main' into chore/remove-register-remotes-warn
ScriptedAlchemy Dec 10, 2024
dc5393d
Merge branch 'main' into chore/remove-register-remotes-warn
ScriptedAlchemy Dec 12, 2024
4223607
chore(runtime): improve language
ScriptedAlchemy Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/funny-drinks-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/runtime': patch
---

chore(runtime): remove duplicate registerRemotes warn
6 changes: 2 additions & 4 deletions packages/runtime/src/remote/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,18 +441,16 @@ export class RemoteHandler {
} else {
const messages = [
`The remote "${remote.name}" is already registered.`,
options?.force
? 'Hope you have known that OVERRIDE it may have some unexpected errors'
: 'If you want to merge the remote, you can set "force: true".',
'Please note that overriding it may cause unexpected errors.',
];
if (options?.force) {
// remove registered remote
this.removeRemote(registeredRemote);
normalizeRemote();
targetRemotes.push(remote);
this.hooks.lifecycle.registerRemote.emit({ remote, origin: host });
warn(messages.join(' '));
}
warn(messages.join(' '));
}
}

Expand Down
Loading