chore(runtime): remove duplicate registerRemotes warn #3325
Conversation
🦋 Changeset detectedLatest commit: 4223607 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
The core changes in this pull request focus on improving the runtime by removing a duplicate warning message when registering a remote that is already registered. The updated code now only displays a single warning message, regardless of whether the remote is being overridden or not. This change helps to simplify the logging and provide a more concise and coherent user experience.
The changes are integrated within the existing codebase, specifically in the packages/runtime/src/remote/index.ts file. The pull request includes updated tests to ensure the new behavior is working as expected, and the documentation has been updated accordingly.
File Summaries
| File | Summary |
|---|---|
| packages/runtime/src/remote/index.ts | The code changes remove a duplicate warning message when registering a remote that is already registered. The updated code now only displays a single warning message, regardless of whether the remote is being overridden or not. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 2
Configuration
Squadron Mode: essential
Commits Reviewed
cafc5f040274ccb274f13d16910146415e8bd973...795010a93879b0133f7612b0ec88e372ffcd0e27
Files Reviewed
- packages/runtime/src/remote/index.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/funny-drinks-bathe.md
Description
remove duplicate registerRemotes warn
Related Issue
Types of changes
Checklist