Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(retry-plugin): allow fallback function to receive failed URL #3133

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ciandt-crodrigues
Copy link

Description

A very simple change allowing the fallback function to receive the failed URL to build the fallback one

Related Issue

New Feature: This was extremely useful to me on my project where I have multiple federated modules and the same host with different base paths depending on the federated module.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 2419e35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/retry-plugin Major
@module-federation/runtime Major
@module-federation/enhanced Major
@module-federation/rspack Major
@module-federation/webpack-bundler-runtime Major
@module-federation/sdk Major
@module-federation/runtime-tools Major
@module-federation/managers Major
@module-federation/manifest Major
@module-federation/dts-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/devtools Major
@module-federation/bridge-react Major
@module-federation/bridge-vue3 Major
@module-federation/bridge-shared Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/modern-js Major
@module-federation/data-prefetch Major
@module-federation/rsbuild-plugin Major
@module-federation/error-codes Major
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 2419e35
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67456ac19f18100008820d95
😎 Deploy Preview https://deploy-preview-3133--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danpeen
Copy link
Contributor

danpeen commented Oct 30, 2024

@ciandt-crodrigues there are some conflicts, please rebase main branch and i'will approval this pr.

@ciandt-crodrigues ciandt-crodrigues force-pushed the main branch 2 times, most recently from a54a1de to a2fcb1c Compare October 30, 2024 12:36
@danpeen
Copy link
Contributor

danpeen commented Nov 11, 2024

@ciandt-crodrigues I think the latest version has solved this issue, please give it a try.

@ciandt-crodrigues
Copy link
Author

@danpeen The latestest version added the same change, just did not include tests.
your call if you close the PR or not, The actual funcionatily is there now

@ScriptedAlchemy
Copy link
Member

if we do not have tests, then we should merge this. Do docs need any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants