-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: shareable runtime #3018
base: main
Are you sure you want to change the base?
feat: shareable runtime #3018
Conversation
…lugin.ts Co-authored-by: squadronai[bot] <170149692+squadronai[bot]@users.noreply.github.com>
…/federation-hooks # Conflicts: # .github/workflows/devtools.yml
🦋 Changeset detectedLatest commit: 88e139b The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incremental Review
Comments posted: 3
Configuration
Squadron Mode: essential
Commits Reviewed
60312e3ef2bff1a2643183734031ba942c0a3b1d...28c24dff89749ee400ac84e491e70d5d3b1e32f8
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-eager-cat.md
- .changeset/ai-eager-tiger.md
- .changeset/ai-gentle-eagle.md
- .changeset/ai-noisy-fox.md
- .changeset/ai-sleepy-bear.md
- .changeset/ai-sleepy-fox.md
- .changeset/real-baboons-complain.md
- .github/workflows/build-and-test.yml
- .github/workflows/e2e-shareruntime.yml
- apps/3000-home/next-env.d.ts
- apps/3001-shop/next-env.d.ts
- apps/3001-shop/next.config.js
- apps/3002-checkout/next-env.d.ts
- apps/shared-runtime/3005-share-host/.babelrc
- apps/shared-runtime/3005-share-host/cypress.config.ts
- apps/shared-runtime/3005-share-host/cypress/e2e/app.cy.ts
- apps/shared-runtime/3005-share-host/cypress/fixtures/example.json
- apps/shared-runtime/3005-share-host/cypress/support/app.po.ts
- apps/shared-runtime/3005-share-host/cypress/support/commands.ts
- apps/shared-runtime/3005-share-host/cypress/support/e2e.ts
- apps/shared-runtime/3005-share-host/cypress/tsconfig.json
- apps/shared-runtime/3005-share-host/package.json
- apps/shared-runtime/3005-share-host/project.json
- apps/shared-runtime/3005-share-host/remotes.d.ts
- apps/shared-runtime/3005-share-host/src/App.tsx
- apps/shared-runtime/3005-share-host/src/Button.tsx
- apps/shared-runtime/3005-share-host/src/Remote1.tsx
- apps/shared-runtime/3005-share-host/src/Remote2.tsx
- apps/shared-runtime/3005-share-host/src/Root.tsx
- apps/shared-runtime/3005-share-host/src/bootstrap.tsx
- apps/shared-runtime/3005-share-host/src/components/ButtonOldAnt.tsx
- apps/shared-runtime/3005-share-host/src/components/stuff.module.css
- apps/shared-runtime/3005-share-host/src/components/stuff.module.css.d.ts
- apps/shared-runtime/3005-share-host/src/index.html
- apps/shared-runtime/3005-share-host/src/index.ts
- apps/shared-runtime/3005-share-host/src/runtimePlugin.ts
- apps/shared-runtime/3005-share-host/src/test-remote-hook.tsx
- apps/shared-runtime/3005-share-host/src/webpack.png
- apps/shared-runtime/3005-share-host/src/webpack.svg
- apps/shared-runtime/3005-share-host/tsconfig.app.json
- apps/shared-runtime/3005-share-host/tsconfig.json
- apps/shared-runtime/3005-share-host/webpack.config.js
- apps/shared-runtime/3006-share-remote/.babelrc
- apps/shared-runtime/3006-share-remote/CHANGELOG.md
- apps/shared-runtime/3006-share-remote/package.json
- apps/shared-runtime/3006-share-remote/project.json
- apps/shared-runtime/3006-share-remote/public/.gitkeep
- apps/shared-runtime/3006-share-remote/public/webpack.png
- apps/shared-runtime/3006-share-remote/public/webpack.svg
- apps/shared-runtime/3006-share-remote/src/App.tsx
- apps/shared-runtime/3006-share-remote/src/Button.tsx
- apps/shared-runtime/3006-share-remote/src/components/WebpackPng.tsx
- apps/shared-runtime/3006-share-remote/src/components/WebpackSvg.tsx
- apps/shared-runtime/3006-share-remote/src/components/a.css
- apps/shared-runtime/3006-share-remote/src/components/useCustomRemoteHook.tsx
- apps/shared-runtime/3006-share-remote/src/index.html
- apps/shared-runtime/3006-share-remote/src/index.tsx
- apps/shared-runtime/3006-share-remote/tsconfig.app.json
- apps/shared-runtime/3006-share-remote/tsconfig.json
- apps/shared-runtime/3006-share-remote/webpack.config.js
- apps/shared-runtime/3007-share-remote/.babelrc
- apps/shared-runtime/3007-share-remote/package.json
- apps/shared-runtime/3007-share-remote/project.json
- apps/shared-runtime/3007-share-remote/src/App.tsx
- apps/shared-runtime/3007-share-remote/src/Button.tsx
- apps/shared-runtime/3007-share-remote/src/components/ButtonOldAnt.tsx
- apps/shared-runtime/3007-share-remote/src/components/stuff.module.css
- apps/shared-runtime/3007-share-remote/src/components/stuff.module.css.d.ts
- apps/shared-runtime/3007-share-remote/src/index.html
- apps/shared-runtime/3007-share-remote/src/index.tsx
- apps/shared-runtime/3007-share-remote/tsconfig.app.json
- apps/shared-runtime/3007-share-remote/tsconfig.json
- apps/shared-runtime/3007-share-remote/webpack.config.js
- apps/shared-runtime/3008-share-remote/CHANGELOG.md
- apps/shared-runtime/3008-share-remote/package.json
- apps/shared-runtime/3008-share-remote/project.json
- apps/shared-runtime/3008-share-remote/rsbuild.config.mjs
- apps/shared-runtime/3008-share-remote/src/App.css
- apps/shared-runtime/3008-share-remote/src/App.jsx
- apps/shared-runtime/3008-share-remote/src/Button.tsx
- apps/shared-runtime/3008-share-remote/src/bootstrap.jsx
- apps/shared-runtime/3008-share-remote/src/index.jsx
- apps/shared-runtime/README.md
- package.json
- packages/enhanced/jest.hoisted.ts
- packages/enhanced/jest.shared.ts
- packages/enhanced/project.json
- packages/enhanced/test/ConfigTestCases.hoistedRuntime.js
- packages/enhanced/test/ConfigTestCases.sharedRuntime.js
- packages/enhanced/test/configCases/container/shareable-runtime/App.js
- packages/enhanced/test/configCases/container/shareable-runtime/ComponentA.js
- packages/enhanced/test/configCases/container/shareable-runtime/index.js
- packages/enhanced/test/configCases/container/shareable-runtime/node_modules/react.js
- packages/enhanced/test/configCases/container/shareable-runtime/test.config.js
- packages/enhanced/test/configCases/container/shareable-runtime/upgrade-react.js
- packages/enhanced/test/configCases/container/shareable-runtime/webpack.config.js
- packages/runtime/tests/snapshots/preload-remote.spec.ts.snap
- packages/runtime/tests/globa.spec.ts
- packages/runtime/tests/global.spec.ts
- packages/runtime/tests/sync.spec.ts
- packages/webpack-bundler-runtime/package.json
- packages/webpack-bundler-runtime/project.json
- packages/webpack-bundler-runtime/src/embedded.ts
- pnpm-lock.yaml
- pnpm-workspace.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incremental Review
Comments posted: 3
Configuration
Squadron Mode: essential
Commits Reviewed
28c24dff89749ee400ac84e491e70d5d3b1e32f8...f236bd1844b868684f977f86edf2ec92c9867fdb
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-eager-cat.md
- .changeset/ai-eager-tiger.md
- .changeset/ai-gentle-eagle.md
- .changeset/ai-noisy-fox.md
- .changeset/ai-sleepy-bear.md
- .changeset/ai-sleepy-fox.md
- .changeset/real-baboons-complain.md
- .github/workflows/build-and-test.yml
- .github/workflows/e2e-shareruntime.yml
- apps/3000-home/next-env.d.ts
- apps/3001-shop/next-env.d.ts
- apps/3001-shop/next.config.js
- apps/3002-checkout/next-env.d.ts
- apps/shared-runtime/3005-share-host/.babelrc
- apps/shared-runtime/3005-share-host/cypress.config.ts
- apps/shared-runtime/3005-share-host/cypress/e2e/app.cy.ts
- apps/shared-runtime/3005-share-host/cypress/fixtures/example.json
- apps/shared-runtime/3005-share-host/cypress/support/app.po.ts
- apps/shared-runtime/3005-share-host/cypress/support/commands.ts
- apps/shared-runtime/3005-share-host/cypress/support/e2e.ts
- apps/shared-runtime/3005-share-host/cypress/tsconfig.json
- apps/shared-runtime/3005-share-host/package.json
- apps/shared-runtime/3005-share-host/project.json
- apps/shared-runtime/3005-share-host/remotes.d.ts
- apps/shared-runtime/3005-share-host/src/App.tsx
- apps/shared-runtime/3005-share-host/src/Button.tsx
- apps/shared-runtime/3005-share-host/src/Remote1.tsx
- apps/shared-runtime/3005-share-host/src/Remote2.tsx
- apps/shared-runtime/3005-share-host/src/Root.tsx
- apps/shared-runtime/3005-share-host/src/bootstrap.tsx
- apps/shared-runtime/3005-share-host/src/components/ButtonOldAnt.tsx
- apps/shared-runtime/3005-share-host/src/components/stuff.module.css
- apps/shared-runtime/3005-share-host/src/components/stuff.module.css.d.ts
- apps/shared-runtime/3005-share-host/src/index.html
- apps/shared-runtime/3005-share-host/src/index.ts
- apps/shared-runtime/3005-share-host/src/runtimePlugin.ts
- apps/shared-runtime/3005-share-host/src/test-remote-hook.tsx
- apps/shared-runtime/3005-share-host/src/webpack.png
- apps/shared-runtime/3005-share-host/src/webpack.svg
- apps/shared-runtime/3005-share-host/tsconfig.app.json
- apps/shared-runtime/3005-share-host/tsconfig.json
- apps/shared-runtime/3005-share-host/webpack.config.js
- apps/shared-runtime/3006-share-remote/.babelrc
- apps/shared-runtime/3006-share-remote/CHANGELOG.md
- apps/shared-runtime/3006-share-remote/package.json
- apps/shared-runtime/3006-share-remote/project.json
- apps/shared-runtime/3006-share-remote/public/.gitkeep
- apps/shared-runtime/3006-share-remote/public/webpack.png
- apps/shared-runtime/3006-share-remote/public/webpack.svg
- apps/shared-runtime/3006-share-remote/src/App.tsx
- apps/shared-runtime/3006-share-remote/src/Button.tsx
- apps/shared-runtime/3006-share-remote/src/components/WebpackPng.tsx
- apps/shared-runtime/3006-share-remote/src/components/WebpackSvg.tsx
- apps/shared-runtime/3006-share-remote/src/components/a.css
- apps/shared-runtime/3006-share-remote/src/components/useCustomRemoteHook.tsx
- apps/shared-runtime/3006-share-remote/src/index.html
- apps/shared-runtime/3006-share-remote/src/index.tsx
- apps/shared-runtime/3006-share-remote/tsconfig.app.json
- apps/shared-runtime/3006-share-remote/tsconfig.json
- apps/shared-runtime/3006-share-remote/webpack.config.js
- apps/shared-runtime/3007-share-remote/.babelrc
- apps/shared-runtime/3007-share-remote/package.json
- apps/shared-runtime/3007-share-remote/project.json
- apps/shared-runtime/3007-share-remote/src/App.tsx
- apps/shared-runtime/3007-share-remote/src/Button.tsx
- apps/shared-runtime/3007-share-remote/src/components/ButtonOldAnt.tsx
- apps/shared-runtime/3007-share-remote/src/components/stuff.module.css
- apps/shared-runtime/3007-share-remote/src/components/stuff.module.css.d.ts
- apps/shared-runtime/3007-share-remote/src/index.html
- apps/shared-runtime/3007-share-remote/src/index.tsx
- apps/shared-runtime/3007-share-remote/tsconfig.app.json
- apps/shared-runtime/3007-share-remote/tsconfig.json
- apps/shared-runtime/3007-share-remote/webpack.config.js
- apps/shared-runtime/3008-share-remote/CHANGELOG.md
- apps/shared-runtime/3008-share-remote/package.json
- apps/shared-runtime/3008-share-remote/project.json
- apps/shared-runtime/3008-share-remote/rsbuild.config.mjs
- apps/shared-runtime/3008-share-remote/src/App.css
- apps/shared-runtime/3008-share-remote/src/App.jsx
- apps/shared-runtime/3008-share-remote/src/Button.tsx
- apps/shared-runtime/3008-share-remote/src/bootstrap.jsx
- apps/shared-runtime/3008-share-remote/src/index.jsx
- apps/shared-runtime/README.md
- package.json
- packages/enhanced/jest.hoisted.ts
- packages/enhanced/jest.shared.ts
- packages/enhanced/project.json
- packages/enhanced/test/ConfigTestCases.hoistedRuntime.js
- packages/enhanced/test/ConfigTestCases.sharedRuntime.js
- packages/enhanced/test/configCases/container/shareable-runtime/App.js
- packages/enhanced/test/configCases/container/shareable-runtime/ComponentA.js
- packages/enhanced/test/configCases/container/shareable-runtime/index.js
- packages/enhanced/test/configCases/container/shareable-runtime/node_modules/react.js
- packages/enhanced/test/configCases/container/shareable-runtime/test.config.js
- packages/enhanced/test/configCases/container/shareable-runtime/upgrade-react.js
- packages/enhanced/test/configCases/container/shareable-runtime/webpack.config.js
- packages/runtime/tests/snapshots/preload-remote.spec.ts.snap
- packages/runtime/tests/globa.spec.ts
- packages/runtime/tests/global.spec.ts
- packages/runtime/tests/sync.spec.ts
- packages/webpack-bundler-runtime/package.json
- packages/webpack-bundler-runtime/project.json
- packages/webpack-bundler-runtime/src/embedded.ts
- pnpm-lock.yaml
- pnpm-workspace.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incremental Review
Comments posted: 4
Configuration
Squadron Mode: essential
Commits Reviewed
f236bd1844b868684f977f86edf2ec92c9867fdb...15c487c83c139d7586e264bfe8af4824d1f210ae
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-eager-cat.md
- .changeset/ai-eager-tiger.md
- .changeset/ai-gentle-eagle.md
- .changeset/ai-noisy-fox.md
- .changeset/ai-sleepy-bear.md
- .changeset/ai-sleepy-fox.md
- .changeset/real-baboons-complain.md
- .github/workflows/build-and-test.yml
- .github/workflows/e2e-shareruntime.yml
- apps/3000-home/next-env.d.ts
- apps/3001-shop/next-env.d.ts
- apps/3001-shop/next.config.js
- apps/3002-checkout/next-env.d.ts
- apps/shared-runtime/3005-share-host/.babelrc
- apps/shared-runtime/3005-share-host/cypress.config.ts
- apps/shared-runtime/3005-share-host/cypress/e2e/app.cy.ts
- apps/shared-runtime/3005-share-host/cypress/fixtures/example.json
- apps/shared-runtime/3005-share-host/cypress/support/app.po.ts
- apps/shared-runtime/3005-share-host/cypress/support/commands.ts
- apps/shared-runtime/3005-share-host/cypress/support/e2e.ts
- apps/shared-runtime/3005-share-host/cypress/tsconfig.json
- apps/shared-runtime/3005-share-host/package.json
- apps/shared-runtime/3005-share-host/project.json
- apps/shared-runtime/3005-share-host/remotes.d.ts
- apps/shared-runtime/3005-share-host/src/App.tsx
- apps/shared-runtime/3005-share-host/src/Button.tsx
- apps/shared-runtime/3005-share-host/src/Remote1.tsx
- apps/shared-runtime/3005-share-host/src/Remote2.tsx
- apps/shared-runtime/3005-share-host/src/Root.tsx
- apps/shared-runtime/3005-share-host/src/bootstrap.tsx
- apps/shared-runtime/3005-share-host/src/components/ButtonOldAnt.tsx
- apps/shared-runtime/3005-share-host/src/components/stuff.module.css
- apps/shared-runtime/3005-share-host/src/components/stuff.module.css.d.ts
- apps/shared-runtime/3005-share-host/src/index.html
- apps/shared-runtime/3005-share-host/src/index.ts
- apps/shared-runtime/3005-share-host/src/runtimePlugin.ts
- apps/shared-runtime/3005-share-host/src/test-remote-hook.tsx
- apps/shared-runtime/3005-share-host/src/webpack.png
- apps/shared-runtime/3005-share-host/src/webpack.svg
- apps/shared-runtime/3005-share-host/tsconfig.app.json
- apps/shared-runtime/3005-share-host/tsconfig.json
- apps/shared-runtime/3005-share-host/webpack.config.js
- apps/shared-runtime/3006-share-remote/.babelrc
- apps/shared-runtime/3006-share-remote/CHANGELOG.md
- apps/shared-runtime/3006-share-remote/package.json
- apps/shared-runtime/3006-share-remote/project.json
- apps/shared-runtime/3006-share-remote/public/.gitkeep
- apps/shared-runtime/3006-share-remote/public/webpack.png
- apps/shared-runtime/3006-share-remote/public/webpack.svg
- apps/shared-runtime/3006-share-remote/src/App.tsx
- apps/shared-runtime/3006-share-remote/src/Button.tsx
- apps/shared-runtime/3006-share-remote/src/components/WebpackPng.tsx
- apps/shared-runtime/3006-share-remote/src/components/WebpackSvg.tsx
- apps/shared-runtime/3006-share-remote/src/components/a.css
- apps/shared-runtime/3006-share-remote/src/components/useCustomRemoteHook.tsx
- apps/shared-runtime/3006-share-remote/src/index.html
- apps/shared-runtime/3006-share-remote/src/index.tsx
- apps/shared-runtime/3006-share-remote/tsconfig.app.json
- apps/shared-runtime/3006-share-remote/tsconfig.json
- apps/shared-runtime/3006-share-remote/webpack.config.js
- apps/shared-runtime/3007-share-remote/.babelrc
- apps/shared-runtime/3007-share-remote/package.json
- apps/shared-runtime/3007-share-remote/project.json
- apps/shared-runtime/3007-share-remote/src/App.tsx
- apps/shared-runtime/3007-share-remote/src/Button.tsx
- apps/shared-runtime/3007-share-remote/src/components/ButtonOldAnt.tsx
- apps/shared-runtime/3007-share-remote/src/components/stuff.module.css
- apps/shared-runtime/3007-share-remote/src/components/stuff.module.css.d.ts
- apps/shared-runtime/3007-share-remote/src/index.html
- apps/shared-runtime/3007-share-remote/src/index.tsx
- apps/shared-runtime/3007-share-remote/tsconfig.app.json
- apps/shared-runtime/3007-share-remote/tsconfig.json
- apps/shared-runtime/3007-share-remote/webpack.config.js
- apps/shared-runtime/3008-share-remote/CHANGELOG.md
- apps/shared-runtime/3008-share-remote/package.json
- apps/shared-runtime/3008-share-remote/project.json
- apps/shared-runtime/3008-share-remote/rsbuild.config.mjs
- apps/shared-runtime/3008-share-remote/src/App.css
- apps/shared-runtime/3008-share-remote/src/App.jsx
- apps/shared-runtime/3008-share-remote/src/Button.tsx
- apps/shared-runtime/3008-share-remote/src/bootstrap.jsx
- apps/shared-runtime/3008-share-remote/src/index.jsx
- apps/shared-runtime/README.md
- package.json
- packages/enhanced/jest.hoisted.ts
- packages/enhanced/jest.shared.ts
- packages/enhanced/project.json
- packages/enhanced/test/ConfigTestCases.hoistedRuntime.js
- packages/enhanced/test/ConfigTestCases.sharedRuntime.js
- packages/enhanced/test/configCases/container/shareable-runtime/App.js
- packages/enhanced/test/configCases/container/shareable-runtime/ComponentA.js
- packages/enhanced/test/configCases/container/shareable-runtime/index.js
- packages/enhanced/test/configCases/container/shareable-runtime/node_modules/react.js
- packages/enhanced/test/configCases/container/shareable-runtime/test.config.js
- packages/enhanced/test/configCases/container/shareable-runtime/upgrade-react.js
- packages/enhanced/test/configCases/container/shareable-runtime/webpack.config.js
- packages/runtime/tests/globa.spec.ts
- packages/runtime/tests/global.spec.ts
- packages/runtime/tests/sync.spec.ts
- packages/webpack-bundler-runtime/package.json
- packages/webpack-bundler-runtime/project.json
- packages/webpack-bundler-runtime/src/embedded.ts
- pnpm-lock.yaml
- pnpm-workspace.yaml
# Conflicts: # pnpm-lock.yaml
d8b0850
to
88e139b
Compare
Description
Ability to share module-federation/runtime from a host system who can provide it
Related Issue
#2579
#2795
Types of changes
Checklist