refactor(vue3-bridge): fix types

module-federation · Dec 8, 2024 · 6d52726 · 6d52726
1 parent 912f5dd
commit 6d52726
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/apps/website-new/docs/en/practice/bridge/vue-bridge.mdx b/apps/website-new/docs/en/practice/bridge/vue-bridge.mdx
@@ -40,7 +40,7 @@ function createBridgeComponent(bridgeInfo: {
     basename?: string;
     memoryRoute?: { entryPath: string };
     [key: string]: any;
-  }) => { router?: Router };
+  }) => { router?: Router } | void;
 }): () => {
   render(info: {
     name?: string;
@@ -210,7 +210,7 @@ function createBridgeComponent(bridgeInfo: {
     basename?: string;
     memoryRoute?: { entryPath: string };
     [key: string]: any;
-  }) => { router?: Router };
+  }) => { router?: Router } | void;
 }): () => {
   render(info: {
     name?: string;

diff --git a/packages/bridge/vue3-bridge/src/provider.ts b/packages/bridge/vue3-bridge/src/provider.ts
@@ -7,18 +7,17 @@ import { getInstance } from '@module-federation/runtime';
 declare const __APP_VERSION__: string;
 
 type AddOptionsFnParams = {
-  rootComponent: Vue.Component;
-  appOptions: (params: {
-    app: Vue.App<Vue.Component>;
-    basename: RenderFnParams['basename'];
-    memoryRoute: RenderFnParams['memoryRoute'];
-    [key: string]: any;
-  }) => { router?: VueRouter.Router } | void;
+  app: Vue.App<Vue.Component>;
+  basename: RenderFnParams['basename'];
+  memoryRoute: RenderFnParams['memoryRoute'];
+  [key: string]: any;
 };
 
 export type ProviderFnParams = {
   rootComponent: Vue.Component;
-  appOptions: (params: AddOptionsFnParams) => { router?: VueRouter.Router };
+  appOptions: (
+    params: AddOptionsFnParams,
+  ) => { router?: VueRouter.Router } | void;
 };
 
 export function createBridgeComponent(bridgeInfo: ProviderFnParams) {