[mojo-stdlib] Fix base64 encode for non ASCII chars #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzaks
changed the title
|
Nice bugfix :) It seems the |
|
LGTM, thank you for the fix! Can you please rebase with the latest nightly branch? CI is using the |
Signed-off-by: Maxim Zaks <[email protected]>
JoeLoser
approved these changes
Apr 3, 2024
whym1here
pushed a commit
to whym1here/mojo
that referenced
this pull request
Apr 5, 2024
This change fixes following bug: modularml#1630. Signed-off-by: Maxim Zaks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes following bug: #1630