-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mojo-stdlib] Import what you use rather than from <module> import *
#2081
[mojo-stdlib] Import what you use rather than from <module> import *
#2081
Conversation
from <module> import *
Hi, thank you for the pull request. It seems that the DCO is missing (the "signed-off-by" in commits). Please head to https://github.com/modularml/mojo/blob/main/CONTRIBUTING.md#signing-your-work and rectify the commit messages. |
@gabrieldemarmiesse is this to be done for all commits or just should i add it to the last commit? |
Signed-off-by: Kaushal Phulgirkar <[email protected]>
Signed-off-by: Kaushal Phulgirkar <[email protected]>
Signed-off-by: Kaushal Phulgirkar <[email protected]>
Signed-off-by: Kaushal Phulgirkar <[email protected]>
Signed-off-by: Kaushal Phulgirkar <[email protected]>
Signed-off-by: Kaushal Phulgirkar <[email protected]>
Signed-off-by: Kaushal Phulgirkar <[email protected]>
7219f7a
to
a44b036
Compare
Got it. Thanks. I have updated the commits |
The changes themselves look good, thank you! Just need to fix up the formatting:
should do the trick for you. |
Signed-off-by: Kaushal Phulgirkar <[email protected]>
modularml#2081) Change the tests to explicitly import what they use rather than using `from <module> import *`. Signed-off-by: Kaushal Phulgirkar <[email protected]>
modularml#2081) Change the tests to explicitly import what they use rather than using `from <module> import *`. Signed-off-by: Kaushal Phulgirkar <[email protected]>
Fixes #2043