Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mojo-stdlib] Import what you use rather than from <module> import * #2081

Conversation

StandinKP
Copy link
Contributor

Fixes #2043

@StandinKP StandinKP requested review from jackos and a team as code owners March 30, 2024 10:13
@StandinKP StandinKP changed the title [mojo-stdlib] Import what you use rather than from <module> import * [mojo-stdlib] Import what you use rather than from <module> import * Mar 30, 2024
@gabrieldemarmiesse
Copy link
Contributor

Hi, thank you for the pull request. It seems that the DCO is missing (the "signed-off-by" in commits). Please head to https://github.com/modularml/mojo/blob/main/CONTRIBUTING.md#signing-your-work and rectify the commit messages.

@StandinKP
Copy link
Contributor Author

Hi, thank you for the pull request. It seems that the DCO is missing (the "signed-off-by" in commits). Please head to https://github.com/modularml/mojo/blob/main/CONTRIBUTING.md#signing-your-work and rectify the commit messages.

@gabrieldemarmiesse is this to be done for all commits or just should i add it to the last commit?

@gabrieldemarmiesse
Copy link
Contributor

gabrieldemarmiesse commented Mar 30, 2024

I believe it must be done on all commits, but it's not clear. For your information, I asked clarification questions to the maintainers here: #2060 and we should get better DX for DCO when completing #2057

@StandinKP StandinKP force-pushed the use_explicit_imports_instead_of_importing_all branch from 7219f7a to a44b036 Compare March 30, 2024 11:29
@StandinKP
Copy link
Contributor Author

Got it. Thanks. I have updated the commits

@JoeLoser
Copy link
Collaborator

JoeLoser commented Apr 3, 2024

The changes themselves look good, thank you! Just need to fix up the formatting:

mojo format -l 80
stdlib/test/builtin/test_simd.mojo
stdlib/test/builtin/test_string.mojo
stdlib/test/collections/test_set.mojo
stdlib/test/memory/test_memory.mojo
stdlib/test/pathlib/test_pathlib.mojo
stdlib/test/test_utils/types.mojo
stdlib/test/utils/test_tuple.mojo
stdlib/test/utils/test_variant.mojo

should do the trick for you.

Signed-off-by: Kaushal Phulgirkar <[email protected]>
@JoeLoser JoeLoser merged commit 48b91b7 into modularml:nightly Apr 3, 2024
5 checks passed
whym1here pushed a commit to whym1here/mojo that referenced this pull request Apr 5, 2024
modularml#2081)

Change the tests to explicitly import what they use rather than using `from <module> import *`.

Signed-off-by: Kaushal Phulgirkar <[email protected]>
helehex pushed a commit to helehex/mojo that referenced this pull request Apr 6, 2024
modularml#2081)

Change the tests to explicitly import what they use rather than using `from <module> import *`.

Signed-off-by: Kaushal Phulgirkar <[email protected]>
@StandinKP StandinKP deleted the use_explicit_imports_instead_of_importing_all branch April 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants