Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit permissions in bulk by using cog names GH#2900 #3202

Closed
wants to merge 4 commits into from
Closed

Edit permissions in bulk by using cog names GH#2900 #3202

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2022

Resolves #2900, a 2 year old feature request.

Have tested this out properly and ironed out all bugs to my understanding. Attached a few screenshots to help understand better.

image
image
image
image

Copy link
Contributor

@Jerrie-Aries Jerrie-Aries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick peek. Looks good. 👍
Got a couple of suggestions there. Thoughts?

Not sure about the .update_perms tho 🤔.

Update:
One more thing, the group name is case sensitive and sometimes it could be multiple words too, if I remember correctly.

cogs/utility.py Outdated Show resolved Hide resolved
cogs/utility.py Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Sep 23, 2022

Update: One more thing, the group name is case sensitive and sometimes it could be multiple words too, if I remember correctly.

Yeah group name is case sensitive, thats why I take it and put it in first letter capitalized, this should work for all inbuilt cogs. For plugins however, they will need to enter the exact class name if it isnt named as first letter capitalised.

And no, class names cant be more than one word so I dont think the group name can be more than one word!

@Jerrie-Aries
Copy link
Contributor

And no, class names cant be more than one word so I dont think the group name can be more than one word!

Yes, class name cannot have multiple words. But cog name could have multiple words (by specifying the name kwarg when creating the class).
bot.get_cog will look for cog name instead of class name.

Cordila and others added 2 commits September 23, 2022 15:16
@ghost
Copy link
Author

ghost commented Sep 23, 2022

Yes, class name cannot have multiple words. But cog name could have multiple words (by specifying the name kwarg when creating the class). bot.get_cog will look for cog name instead of class name.

Cant they just use "cog name" 😕
I feel like to allow more than 1 word cog names will be very difficult.

@Taaku18 Taaku18 linked an issue Jul 11, 2023 that may be closed by this pull request
@ghost ghost closed this by deleting the head repository Apr 24, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk Permissions override [Command request]
2 participants