Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First take on specification resolution mechanisms #19

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Aug 11, 2024

No description provided.

@mjreno
Copy link
Contributor Author

mjreno commented Aug 12, 2024

This PR introduces mechanisms to resolve out of context input:

  • A Resolve type that maps memory paths strings to an existing input object hierarchy
  • A load based mechanism to pass params from previously read blocks (Options/Dimensions currently) downwards to a later read context

To test/demonstrate, some incomplete code has been added:

  • simulation.py has an incomplete load classmethod intended to temporarily support loading a gwf model. It also instantiates the resolve singleton instance.
  • model.py has an incomplete load classmethod inteded to temporarily support loading a model packages block without existing MFList support.

@wpbonelli a hand written example file has been added (spec/ipkg/gwf_ic.v2.py) as a possible next step for generated package python files. In the example, parameter definitions have been moved to a member list and adjustments would need to make to existing objects to accommodate such a change.

@mjreno mjreno merged commit 8e7b53a into modflowpy:develop Aug 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant