Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cvfdutil): fix skip_hanging_node_check #2423

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

oscarfasanchez
Copy link
Contributor

@oscarfasanchez oscarfasanchez commented Jan 21, 2025

vertexdict_keys was put out of the if condition skip_hanging_node_check, to avoid failure if the check is not necessary on some grids
Related to issue #2321

Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oscarfasanchez I moved the vertexdict_keys assignment above the conditional since it's needed both within it and below.

Not sure why the check might hang indefinitely in your use case. Can you send us the script to reproduce it? Presumably that while loop is never exited.

@wpbonelli wpbonelli changed the title cvdutil fix for skip_hanging_node_check fix(cvdutil): fix skip_hanging_node_check Jan 21, 2025
@wpbonelli wpbonelli changed the title fix(cvdutil): fix skip_hanging_node_check fix(cvfdutil): fix skip_hanging_node_check Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.3%. Comparing base (bb9824e) to head (17c7c98).
Report is 38 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2423     +/-   ##
=========================================
+ Coverage     68.4%   76.3%   +7.8%     
=========================================
  Files          294     294             
  Lines        59390   59855    +465     
=========================================
+ Hits         40652   45690   +5038     
+ Misses       18738   14165   -4573     
Files with missing lines Coverage Δ
flopy/utils/cvfdutil.py 82.5% <100.0%> (ø)

... and 247 files with indirect coverage changes

@wpbonelli wpbonelli merged commit f9da244 into modflowpy:develop Jan 21, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants