fix(resolve_exe): allow shutil.which() to find exe without suffix in Windows #2408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address an issue found in local testing in
Windows
withPython 3.13.1
. The issue is seen in the failing test:test_mbase.py::test_run_model_exe_rel_path
and is caused by a behavior change inshutil.which
(in Windows) introduced in python/cpython#127035.For more context, in
test_run_model_exe_rel_path
, the mf6 executable is copied to a relative path,../bin/mf6
(without extension). Within the test,shutil.which
is used to locate the executable path. However, with the new changes inshutil.which
, by default, it would only search for the path with an extension inPATHEXT
, excluding paths without extension.