-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(Mf6Splitter): added split_multi_model method #2352
Conversation
jlarsen-usgs
commented
Nov 2, 2024
- split_multi_model method allows splitting of connected GWF-GWT models
- update exchange remapping for GWT support
* split_multi_model method allows splitting of connected GWF-GWT models * update exchange remapping for GWT support
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2352 +/- ##
=========================================
- Coverage 74.4% 74.3% -0.1%
=========================================
Files 292 292
Lines 59526 59617 +91
=========================================
+ Hits 44308 44325 +17
- Misses 15218 15292 +74
|
Hey @jlarsen-usgs , I looked at the failing test and realized I was having similar issues. The storage package is created with:
which the splitter can't process into something valid. Reducing it to:
works as intended. |
Thanks for pointing this out. I was at a loss yesterday afternoon as to what the difference was, because it runs fine on windows. I'll look into this some more; I should be able to put together a fix for mapping those records to the split models. |