Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(Mf6Splitter): added split_multi_model method #2352

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

jlarsen-usgs
Copy link
Contributor

  • split_multi_model method allows splitting of connected GWF-GWT models
  • update exchange remapping for GWT support

* split_multi_model method allows splitting of connected GWF-GWT models
* update exchange remapping for GWT support
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 19.23077% with 84 lines in your changes missing coverage. Please review.

Project coverage is 74.3%. Comparing base (9349a07) to head (7df5c7b).

Files with missing lines Patch % Lines
flopy/mf6/utils/model_splitter.py 19.2% 84 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2352     +/-   ##
=========================================
- Coverage     74.4%   74.3%   -0.1%     
=========================================
  Files          292     292             
  Lines        59526   59617     +91     
=========================================
+ Hits         44308   44325     +17     
- Misses       15218   15292     +74     
Files with missing lines Coverage Δ
flopy/mf6/utils/model_splitter.py 67.4% <19.2%> (-3.1%) ⬇️

... and 3 files with indirect coverage changes

@mjr-deltares
Copy link
Contributor

Hey @jlarsen-usgs , I looked at the failing test and realized I was having similar issues. The storage package is created with:

        ... 
        steady_state={0: True, 1: False},
        transient={0: False, 1: True},
    )

which the splitter can't process into something valid. Reducing it to:


    steady_state={0: True},
    transient={1 : True},
)

works as intended.

@jlarsen-usgs
Copy link
Contributor Author

@mjr-deltares

Thanks for pointing this out. I was at a loss yesterday afternoon as to what the difference was, because it runs fine on windows. I'll look into this some more; I should be able to put together a fix for mapping those records to the split models.

@jlarsen-usgs jlarsen-usgs marked this pull request as ready for review November 6, 2024 00:56
@jlarsen-usgs jlarsen-usgs merged commit acc5a5b into modflowpy:develop Nov 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants