Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(format): apply isort rule, update default rules #2137

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Apr 4, 2024

  • extend default rules in pyproject.toml
  • apply import sorting
  • fix line lengths: demo what's needed to fully observe E501
    • flopy/version.py
    • update_version.py
    • flopy/utils/zonbud.py
  • ignore other line length violations in comments for now

* ignore line length violations in comments for now
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.0%. Comparing base (aa9f410) to head (e2c4299).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2137   +/-   ##
=======================================
  Coverage     73.0%   73.0%           
=======================================
  Files          260     260           
  Lines        59483   59483           
=======================================
  Hits         43482   43482           
  Misses       16001   16001           
Files Coverage Δ
flopy/utils/modpathfile.py 88.4% <100.0%> (ø)
flopy/utils/particletrackfile.py 96.0% <100.0%> (ø)
flopy/utils/zonbud.py 66.8% <ø> (ø)
flopy/version.py 100.0% <ø> (ø)

@wpbonelli wpbonelli marked this pull request as ready for review April 4, 2024 18:02
@wpbonelli wpbonelli merged commit 4c717cb into modflowpy:develop Apr 4, 2024
24 checks passed
@wpbonelli wpbonelli deleted the ruff-isort branch April 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant