Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mbase): append not prepend flopy bindir to PATH #2037

Merged
merged 1 commit into from
Dec 8, 2023
Merged

refactor(mbase): append not prepend flopy bindir to PATH #2037

merged 1 commit into from
Dec 8, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli marked this pull request as ready for review December 8, 2023 13:15
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

Merging #2037 (6d9ae7a) into develop (5a4533b) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is 100.0%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #2037   +/-   ##
=======================================
  Coverage     72.9%   72.9%           
=======================================
  Files          259     259           
  Lines        59049   59049           
=======================================
  Hits         43066   43066           
  Misses       15983   15983
Files Coverage Δ
flopy/mbase.py 69.9% <100.0%> (ø)

@wpbonelli wpbonelli merged commit 66b1862 into modflowpy:develop Dec 8, 2023
23 checks passed
@wpbonelli wpbonelli deleted the get-modflow branch December 8, 2023 16:24
@wpbonelli wpbonelli mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

@mwtoews mwtoews Awaiting requested review from mwtoews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing flopy modfies PATH environment variable and overrides user settings
2 participants
@wpbonelli @dbrakenhoff