Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Mf6Splitter): preserve MFSimulation version & exe_name #2033

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Dec 7, 2023

@wpbonelli wpbonelli marked this pull request as ready for review December 7, 2023 14:18
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #2033 (7d823e0) into develop (c223c97) will increase coverage by 1.7%.
Report is 2 commits behind head on develop.
The diff coverage is 100.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2033     +/-   ##
=========================================
+ Coverage     71.1%   72.9%   +1.7%     
=========================================
  Files          259     259             
  Lines        57665   59047   +1382     
=========================================
+ Hits         41029   43064   +2035     
+ Misses       16636   15983    -653     
Files Coverage Δ
flopy/mf6/utils/model_splitter.py 69.9% <100.0%> (+<0.1%) ⬆️

... and 103 files with indirect coverage changes

@jlarsen-usgs jlarsen-usgs merged commit 44abb51 into modflowpy:develop Dec 7, 2023
23 checks passed
@wpbonelli wpbonelli deleted the splitter-exe branch December 7, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: pass exe_name to new simulation in Mf6Splitter
2 participants