fix(recarrays with cellid): fixes bug when setting data as recarrays with cellids #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with layer/row/column fields (instead of cellid tuple)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2029 +/- ##
=========================================
Coverage 72.8% 72.9%
=========================================
Files 259 259
Lines 57665 59047 +1382
=========================================
+ Hits 42032 43064 +1032
- Misses 15633 15983 +350
|
langevin-usgs
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is specifically for setting flopy data with recarrays that contain cellids broken out by layer, row, column instead of as a cellid tuple. Flopy now automatically converts the layer, row, and column into a tuple for storage.