Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get_disu_kwargs): incorrect indexing of delr and delc #2011

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

langevin-usgs
Copy link
Contributor

@langevin-usgs langevin-usgs commented Nov 20, 2023

  • delr is of size (ncol) and delc is of size (nrow). get_disu_kwargs had it wrong in a couple spots.
  • Added test to show that the problem is fixed
  • Updated get_disu_kwargs to optionally return vertices and cell2d

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #2011 (47b080f) into develop (7cc5e6f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2011   +/-   ##
=======================================
  Coverage     72.7%   72.8%           
=======================================
  Files          259     259           
  Lines        58956   58992   +36     
=======================================
+ Hits         42916   42952   +36     
  Misses       16040   16040           
Files Coverage Δ
flopy/utils/gridutil.py 98.1% <100.0%> (+0.3%) ⬆️

@langevin-usgs langevin-usgs merged commit 419ae0e into modflowpy:develop Nov 21, 2023
24 checks passed
@langevin-usgs langevin-usgs deleted the patch-gridutil branch November 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant