Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MfSimulationList): add functionality to parse the mfsim.lst file #2005

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

jdhughes-usgs
Copy link
Contributor

  • add testing for MfSimulationList

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2005 (e89a41d) into develop (16183c3) will increase coverage by 1.7%.
The diff coverage is 91.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2005     +/-   ##
=========================================
+ Coverage     70.9%   72.7%   +1.7%     
=========================================
  Files          258     259      +1     
  Lines        57456   58955   +1499     
=========================================
+ Hits         40791   42915   +2124     
+ Misses       16665   16040    -625     
Files Coverage Δ
flopy/mf6/utils/__init__.py 100.0% <100.0%> (ø)
flopy/mf6/utils/mfsimlistfile.py 91.7% <91.7%> (ø)

... and 103 files with indirect coverage changes


@requires_exe("mf6")
def test_mfsimlist_memory(function_tmpdir):
virtual_answer = 0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess this is because virtual memory is only used for mf6 parallel at the moment — once flopy has more parallel support a parallel test case could be added to check virtual memory usage I imagine

@jdhughes-usgs jdhughes-usgs merged commit b34f154 into modflowpy:develop Nov 14, 2023
24 checks passed
@jdhughes-usgs jdhughes-usgs deleted the feat-mfsimlst branch November 15, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants