Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/composer required package installs update #1076

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Task/composer required package installs update #1076

merged 5 commits into from
Sep 3, 2024

Conversation

dpellenwood
Copy link
Contributor

What does this do/fix?

  • Removes Gravity Forms as a composer dependency as it's doesn't technically work.
  • Moves ACF Pro to use their recommended approach.

@dpellenwood dpellenwood requested a review from JMRhodes September 3, 2024 19:39
JMRhodes
JMRhodes approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@JMRhodes JMRhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpellenwood dpellenwood force-pushed the task/composer-required-package-installs-update branch from 857a594 to ace8129 Compare September 3, 2024 20:15
@dpellenwood dpellenwood merged commit 9546bd5 into main Sep 3, 2024
10 of 12 checks passed
@dpellenwood dpellenwood deleted the task/composer-required-package-installs-update branch September 3, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMRhodes JMRhodes JMRhodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpellenwood @JMRhodes