[BLOCK] Custom Query Loop #7
Conversation
GeoffDusome
added
Needs FE Review
GeoffDusome
requested review from
Vinsanity,
JMRhodes,
bjcooper,
LayaTaal and
lindseyolson
There was a problem hiding this comment.
@GeoffDusome I'm going to continue going through this but want to leave individual comments as I do.
I left a few small thoughts here for now. Also, I wanted to share this screencast of a bug I encountered on the admin side.
|
|
||
| .page-numbers:not(.dots, .next, .prev) { | ||
|
|
||
| @mixin t-body; |
There was a problem hiding this comment.
I wonder if we should think about doing this differently. I know these are intended to be used only with Moose, but it feels a little uncomfortable to be relying on mixins and variables from a different codebase where they may change or not be present at all.
| <h2 class="p-card-search-result__title t-display-x-small" style="margin-top: 0; margin-bottom: var(--wp--preset--spacing--10)"><?php echo get_the_title( $id ); ?></h2> | ||
|
|
||
| <p class="p-card-search-result__excerpt"><?php echo get_the_excerpt( $id ); ?></p> | ||
|
|
||
| <p class="p-card-search-result__permalink t-caption" style="margin-top: var(--wp--preset--spacing--20); color: var(--color-neutral-60)"><?php echo get_the_permalink( $id ); ?></p> |
| <FormTokenField | ||
| __next40pxDefaultSize={ true } | ||
| label={ __( 'Post Types', 'tribe' ) } | ||
| value={ postTypes } | ||
| suggestions={ postTypeSuggestions() } | ||
| onChange={ ( tokens ) => { | ||
| setPostTypes( tokens ); | ||
| } } |
There was a problem hiding this comment.
I am finding these form token fields a little confusing to use. Maybe we can add more helper text or change the control type? It just wasn't clear to me that typing would bring up a list of available post types.
| } } | ||
| /> | ||
| { postTypes !== null && postTypes.length > 0 ? ( | ||
| <FormTokenField |
There was a problem hiding this comment.
Same comment here about the form token field
Custom Query Loop
What does this do/fix?
A dynamic block with some supporting components to create the ability to define a custom query loop that gives us more features than that of the core Query block.
How can this be quickly implemented for testing?
blockdirectory to thethemes/core/blocks/tribe/custom-query-loop/directory.componentsdirectory to thethemes/coredirectory.tribe/custom-query-loopblock to theself::TYPESarray inplugins/core/src/Blocks/Blocks_Definer.php.npm run distto build the block.Media