-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for cmake use of neural-fortran #192
Update for cmake use of neural-fortran #192
Conversation
Huh. I didn't seem to trigger the CI... |
Also: I don't know how to use |
I think the CI is configured to only trigger CI on source changes. We should fix that! Thanks for this, will test. fpm doesn't care about this part. |
Ahh. I could update that in my PR? We can add |
Okay, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks @mathomp4, I'm not merging in case you're still working on it, let me know when good to merge. |
@milancurcic I think I'm good. Once it's in, I'll give it a test but this works for me! |
Thanks for merging! I'll work with |
I recently tried building
neural-fortran
and then wanted to try and use it with an external code (which were essentially the examples herein).In doing so, I couldn't quite get the current
Findneural-fortran.cmake
file from #178 (via #166) to work for me.So, I did some hacking around and came up with this PR. The changes are:
Findneural-fortran.cmake
file. The original was a bit above me so I made something a bit easier to use. For this one, a user needs to setneural-fortran_ROOT_DIR
such thatneural-fortran_ROOT_DIR/lib/libneural-fortran.a
exists. It also looks for the.mod
files as those are also needed for external use..mod
files toCMAKE_INSTALL_PREFIX/include
so that they can be found by thefind_package
Findneural-fortran.cmake
inCMAKE_INSTALL_PREFIX/include/cmake/neural-fortran
...which might not be the best place. I just wanted to put it somewhere in the installIn my testing, this all seems to work both for external and internal use. For example:
all worked and the examples seem to as well.
I'm going to keep this draft (for now) until @milancurcic can test. I'd also like to make sure I haven't broken the workflow of @jvdp1 who added the first
Findneural-fortran.cmake
file. And I guess I'll ping @aminiussi who is the filer of #166