-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing RAG module into package #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comments, thx
# Conflicts: # src/agentscope/models/dashscope_model.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments
# Conflicts: # src/agentscope/agents/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz see inline comments, and I think the RAG module is still not ready for using.
- For me, I cannot find how to set
rag_config
in docstring and example: what parameters should be included and their constraints, and what format should the parameters follow. - RAG-related documents are suggested, maybe add a RAG section in tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Introducing RAG module into AgentScope package
Description
Introducing retrieval augmented generation techniques into AgentScope package to enrich the ability of agents.
To accommodate the RAG process of different packages, we abstract the RAG process into four stages:
Checklist
Please check the following items before code is ready to be reviewed.