Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DashScope model wrapper into AgentScope #54

Merged
merged 21 commits into from
Mar 14, 2024
Merged

Add DashScope model wrapper into AgentScope #54

merged 21 commits into from
Mar 14, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Mar 8, 2024

-) Raise RuntimeError when the response of Tongyi is not valid
-) preprocess the roles in messages before calling Tongyi model

DavdGao
DavdGao reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

src/agentscope/models/tongyi_model.py Outdated Show resolved Hide resolved
src/agentscope/models/tongyi_model.py Outdated Show resolved Hide resolved
src/agentscope/models/tongyi_model.py Outdated Show resolved Hide resolved
DavdGao
DavdGao reviewed Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz see inline comments

src/agentscope/models/tongyi_model.py Outdated Show resolved Hide resolved
src/agentscope/models/tongyi_model.py Outdated Show resolved Hide resolved
@DavdGao DavdGao changed the title Add Raising error for Tongyi Add DashScope model wrapper into AgentScope Mar 12, 2024
@DavdGao DavdGao added feature enhancement New feature or request and removed feature labels Mar 12, 2024
DavdGao
DavdGao reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz see inline comments

src/agentscope/models/__init__.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
rayrayraykk
rayrayraykk reviewed Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments.

Please remove all spm=xxxx in the URLs.

src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
DavdGao
DavdGao reviewed Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline comments, others lgtm

src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
pan-x-c
pan-x-c approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 98a98c9 into modelscope:main Mar 14, 2024
4 checks passed
@DavdGao DavdGao linked an issue Mar 14, 2024 that may be closed by this pull request
Support DashScope model API #50
Closed
@qbc2016 qbc2016 deleted the dev_tongyi_role branch August 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao left review comments

@rayrayraykk rayrayraykk rayrayraykk left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DashScope model API
4 participants
@qbc2016 @pan-x-c @rayrayraykk @DavdGao