Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to serialize message objects in AgentScope and remove unused arguments. #388

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Support to serialize message objects in AgentScope and remove unused arguments. #388

merged 10 commits into from
Aug 27, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Aug 6, 2024 •
edited
Loading

Description

About Serialization

  1. Add a new serialize and deserialize function in AgentScope, which is responsible for serialization and deserialization in our library in the future;

About Message [IMPORTANT CHANGE]

  1. Msg class doesn't inherit dict any more.
  2. Remove timestamp and name variables from local attributes of placeholder class, since they are actually decided by the distributed agent.
  3. Remove MessageBase class

Others

  1. Remove unused parameter memory_config from the memory module;
  2. Add test for message class
  3. Modify unit tests accordingly

Note

In this PR, we only serialize and deserialize the message objects, leaving agent serialization in the future to keep this PR compact and simple.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

DavdGao added 3 commits August 6, 2024 19:04
@DavdGao
1. Remove unused parameter memory_config from the memory module; 2.…
ed9d59b 
… Add a new serialize and deserialize function in AgentScope
@DavdGao
[DONE] Remove MessageBase class; Message doesn't inherit from dict an…
f362d5f 
…ymore; Unify msg serialization in both local and distribute scenarios and pass all unittests locally; Add new test for message; Fix errors in distribution.
@DavdGao
Merge remote-tracking branch 'modelscope/main' into dev/deserialize_msg
3000472 
# Conflicts:
#	src/agentscope/logging.py
#	src/agentscope/server/servicer.py
@DavdGao DavdGao added enhancement New feature or request ready for review labels Aug 9, 2024
ZiTao-Li
ZiTao-Li reviewed Aug 9, 2024
View reviewed changes
src/agentscope/agents/dialog_agent.py Show resolved Hide resolved
src/agentscope/message/msg.py Outdated Show resolved Hide resolved
src/agentscope/message/msg.py Show resolved Hide resolved
@DavdGao DavdGao merged commit bc2e24b into modelscope:main Aug 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiTao-Li ZiTao-Li ZiTao-Li left review comments

@pan-x-c pan-x-c pan-x-c left review comments

@qbc2016 qbc2016 qbc2016 left review comments

@xieyxclack xieyxclack Awaiting requested review from xieyxclack

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

@garyzhang99 garyzhang99 Awaiting requested review from garyzhang99

@FredericW FredericW Awaiting requested review from FredericW

Assignees
No one assigned
Labels
enhancement New feature or request ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavdGao @qbc2016 @pan-x-c @ZiTao-Li