Support to serialize message objects in AgentScope and remove unused arguments. #388
+849
−502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Add a new serialize and deserialize function in AgentScope
…ymore; Unify msg serialization in both local and distribute scenarios and pass all unittests locally; Add new test for message; Fix errors in distribution.
# Conflicts: # src/agentscope/logging.py # src/agentscope/server/servicer.py
DavdGao
requested review from
qbc2016,
xieyxclack,
pan-x-c,
rayrayraykk,
garyzhang99,
ZiTao-Li and
FredericW
ZiTao-Li
reviewed
Aug 9, 2024
pan-x-c
reviewed
Aug 13, 2024
qbc2016
reviewed
Aug 14, 2024
# Conflicts: # src/agentscope/logging.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
About Serialization
About Message [IMPORTANT CHANGE]
Msgclass doesn't inheritdictany more.timestampandnamevariables from local attributes of placeholder class, since they are actually decided by the distributed agent.MessageBaseclassOthers
memory_configfrom the memory module;Note
In this PR, we only serialize and deserialize the message objects, leaving agent serialization in the future to keep this PR compact and simple.
Checklist
Please check the following items before code is ready to be reviewed.