Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tripadvisor tool functions #332

Merged
merged 21 commits into from
Aug 28, 2024

Conversation

zyzhang1130
Copy link
Contributor

@zyzhang1130 zyzhang1130 commented Jul 11, 2024


name: Pull Request
about: Create a pull request

Description

“Added TripAdvisor API service function to agentscope/service/web for searching geographic locations.” For the detailed usage see the docstrings of the respective service function.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

src/agentscope/service/web/tripadvisor.py Outdated Show resolved Hide resolved
src/agentscope/service/web/tripadvisor.py Outdated Show resolved Hide resolved
src/agentscope/service/web/tripadvisor.py Show resolved Hide resolved
src/agentscope/service/web/tripadvisor.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZiTao-Li ZiTao-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also update the English&Chinese version of tutorial tutorial/204-service.html

@zyzhang1130
Copy link
Contributor Author

LGTM, please also update the English&Chinese version of tutorial tutorial/204-service.html

Done.

Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz see inline comments, others lgtm

src/agentscope/service/__init__.py Outdated Show resolved Hide resolved
src/agentscope/service/web/tripadvisor.py Outdated Show resolved Hide resolved
src/agentscope/service/web/tripadvisor.py Show resolved Hide resolved
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit f0113e5 into modelscope:main Aug 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants