Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hot fix]Fix parse_func and fault_handler of ModelWrapper #31

Merged
merged 2 commits into from
Feb 21, 2024
Merged

[Hot fix]Fix parse_func and fault_handler of ModelWrapper #31

merged 2 commits into from
Feb 21, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Feb 20, 2024

Description

As the title says

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c added the bug Something isn't working label Feb 20, 2024
@pan-x-c pan-x-c requested review from DavdGao and qbc2016 February 20, 2024 07:17
@pan-x-c pan-x-c self-assigned this Feb 20, 2024
@qbc2016 qbc2016 mentioned this pull request Feb 20, 2024
Closed
DavdGao
DavdGao reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

src/agentscope/agents/dict_dialog_agent.py Show resolved Hide resolved
src/agentscope/agents/dict_dialog_agent.py Show resolved Hide resolved
src/agentscope/models/model.py Show resolved Hide resolved
DavdGao
DavdGao approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 56478f3 into modelscope:main Feb 21, 2024
3 checks passed
rayrayraykk pushed a commit that referenced this pull request Feb 26, 2024
@ZiTao-Li
Merge pull request #31 from ZiTao-Li/dev_weirui
e087377 
System window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

@qbc2016 qbc2016 Awaiting requested review from qbc2016

Assignees

@pan-x-c pan-x-c

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan-x-c @DavdGao