Allow to build without distutils #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 12, 2024
Closed
|
@jschueller is this ready for review? |
|
yes |
|
@jschueller have you been able to run the tests locally with Python 3.12? Our github actions is still on 3.9 so just want to know what has been tested before approving. I guess this PR is also dependent on this PR modelon-community/Assimulo#98, is that correct? Many thanks in advance! |
modelonrobinandersson
requested review from
PeterMeisrimelModelon and
modelonrobinandersson
|
yes, I tested this since this is how its patched in conda-forge, and indeed to build assimulo too you need the same in assimulo first |
modelonrobinandersson
approved these changes
Jun 14, 2024
|
done |
modelonrobinandersson
approved these changes
Jun 14, 2024
PeterMeisrimelModelon
approved these changes
Jun 20, 2024
jschueller
force-pushed
the
distutils
branch
2 times, most recently
from
e7e799f to
2615c1a
Compare
|
ok to merge |
modelonrobinandersson
merged commit be9067d
into
modelon-community:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use Python 3.12
it drops the no_msvcr and prefix options (that can be worked around with building the wheel then using pip --target-dir)