-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nose to pytest conversion #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor comments.
Do all the tests pass on both Windows and Linux?
494b9c4
to
5b84da8
Compare
6de1596
to
f518286
Compare
ff7600e
to
da89a54
Compare
4ec2dbf
to
99acd1a
Compare
fd0e835
to
cbec849
Compare
eda3a4b
to
65404d0
Compare
8223755
to
881d530
Compare
881d530
to
dcd393f
Compare
Resolving some Warnings; Adding pytest.ini Fixing deprecationWarnings cleanup Apply suggestions from code review Co-authored-by: Robin Andersson <[email protected]> More review comment fixes Adding pytest.ini to test folder for automatic detection rebase fix replacing nose
more rebase fixes more rebase cleanup more rebase cleanup Removing tests as module; moved test files to tests/files moved test_util to pyfmi/src Adding pytest config fixed example path replaced tests conditional to Assimulo installation by markers simplified workflow file; added changelog
54f3935
to
420081b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice nicely done with the clean-up also!
I am approving since I had just minor optional comments.
All the tests pass on both Windows and Linux. |
No description provided.