draft: add transport parameter to dev command so that server starts in correct transport mode and passes URL to the inspector
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Thank you. Makes sense, but I am requesting changes since I don't want us to listen by default on all ips. Probably we want some sort of --address or --listen parameter that can be specified optionally when transport is SSE, and that defaults to localhost:8000
|
|
||
| env = dict(os.environ.items()) # Convert to list of tuples for env update | ||
| if transport == Transport.SSE: | ||
| env["SSE_HOSTPORT"] = "0.0.0.0:8000" |
There was a problem hiding this comment.
We shouldn't listen by default on every connection, but only localhost, which we should designate as localhost:8000 and use the system mechanism to translate it to socketaddresses, so we cover both ipv4 and ipv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context