-
Notifications
You must be signed in to change notification settings - Fork 141
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #137 from modelcontextprotocol/v1.2.x
fix: #129 resource template handling in FastMCP server
- Loading branch information
Showing
6 changed files
with
98 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
""" | ||
FastMCP Example showing parameter descriptions | ||
""" | ||
|
||
from pydantic import Field | ||
|
||
from mcp.server.fastmcp import FastMCP | ||
|
||
# Create server | ||
mcp = FastMCP("Parameter Descriptions Server") | ||
|
||
|
||
@mcp.tool() | ||
def greet_user( | ||
name: str = Field(description="The name of the person to greet"), | ||
title: str = Field(description="Optional title like Mr/Ms/Dr", default=""), | ||
times: int = Field(description="Number of times to repeat the greeting", default=1), | ||
) -> str: | ||
"""Greet a user with optional title and repetition""" | ||
greeting = f"Hello {title + ' ' if title else ''}{name}!" | ||
return "\n".join([greeting] * times) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import pytest | ||
|
||
from mcp import types | ||
from mcp.server.fastmcp import FastMCP | ||
|
||
|
||
@pytest.mark.anyio | ||
async def test_resource_templates(): | ||
# Create an MCP server | ||
mcp = FastMCP("Demo") | ||
|
||
# Add a dynamic greeting resource | ||
@mcp.resource("greeting://{name}") | ||
def get_greeting(name: str) -> str: | ||
"""Get a personalized greeting""" | ||
return f"Hello, {name}!" | ||
|
||
@mcp.resource("users://{user_id}/profile") | ||
def get_user_profile(user_id: str) -> str: | ||
"""Dynamic user data""" | ||
return f"Profile data for user {user_id}" | ||
|
||
# Get the list of resource templates using the underlying server | ||
# Note: list_resource_templates() returns a decorator that wraps the handler | ||
# The handler returns a ServerResult with a ListResourceTemplatesResult inside | ||
result = await mcp._mcp_server.request_handlers[types.ListResourceTemplatesRequest]( | ||
types.ListResourceTemplatesRequest( | ||
method="resources/templates/list", params=None, cursor=None | ||
) | ||
) | ||
assert isinstance(result.root, types.ListResourceTemplatesResult) | ||
templates = result.root.resourceTemplates | ||
|
||
# Verify we get both templates back | ||
assert len(templates) == 2 | ||
|
||
# Verify template details | ||
greeting_template = next(t for t in templates if t.name == "get_greeting") | ||
assert greeting_template.uriTemplate == "greeting://{name}" | ||
assert greeting_template.description == "Get a personalized greeting" | ||
|
||
profile_template = next(t for t in templates if t.name == "get_user_profile") | ||
assert profile_template.uriTemplate == "users://{user_id}/profile" | ||
assert profile_template.description == "Dynamic user data" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
"""Test that parameter descriptions are properly exposed through list_tools""" | ||
|
||
import pytest | ||
from pydantic import Field | ||
|
||
from mcp.server.fastmcp import FastMCP | ||
|
||
|
||
@pytest.mark.asyncio | ||
async def test_parameter_descriptions(): | ||
mcp = FastMCP("Test Server") | ||
|
||
@mcp.tool() | ||
def greet( | ||
name: str = Field(description="The name to greet"), | ||
title: str = Field(description="Optional title", default=""), | ||
) -> str: | ||
"""A greeting tool""" | ||
return f"Hello {title} {name}" | ||
|
||
tools = await mcp.list_tools() | ||
assert len(tools) == 1 | ||
tool = tools[0] | ||
|
||
# Check that parameter descriptions are present in the schema | ||
properties = tool.inputSchema["properties"] | ||
assert "name" in properties | ||
assert properties["name"]["description"] == "The name to greet" | ||
assert "title" in properties | ||
assert properties["title"]["description"] == "Optional title" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.