Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic toolchain upgrade to nightly-2023-08-20 #2698

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Update Rust toolchain from nightly-2023-08-19 to nightly-2023-08-20 without any other source changes.
This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang/rust@d06ca0f up to rust-lang/rust@6ef7d16. The log for this commit range is:
rust-lang/rust@6ef7d16be0 Auto merge of #114979 - weihanglo:update-cargo, r=weihanglo
rust-lang/rust@3e50a641da Auto merge of #114980 - matthiaskrgr:rollup-3y7651q, r=matthiaskrgr
rust-lang/rust@07ff87bf73 Update cargo
rust-lang/rust@8e0a8cdecb Rollup merge of #114977 - kpreid:modulo, r=thomcc
rust-lang/rust@d8bde4878a Rollup merge of #114972 - nbdd0121:const_check, r=compiler-errors
rust-lang/rust@8d52b4d2f3 Rollup merge of #114971 - kpreid:trig, r=joshtriplett
rust-lang/rust@2b13128be8 Rollup merge of #114958 - ferrocene:optimization-remarks-dir-pgo, r=lqd
rust-lang/rust@0e609c4610 Rollup merge of #114953 - WaffleLapkin:waffle-back-to-rotation-hehehee, r=WaffleLapkin
rust-lang/rust@2c21635382 Add modulo and mod as doc aliases for rem_euclid.
rust-lang/rust@26fe88fedb Add a test to check that inline const is in required_consts
rust-lang/rust@c353dbd57f Add doc aliases for trigonometry and other f32,f64 methods.
rust-lang/rust@fb148f682e ignore-cross-compile on optimization-remarks-dir-pgo test
rust-lang/rust@54bd826d56 Add waffle back to review rotation

@github-actions github-actions bot requested a review from a team as a code owner August 20, 2023 02:32
@zhassan-aws zhassan-aws reopened this Aug 20, 2023
@zhassan-aws zhassan-aws added the Z-BenchCI Tag a PR to run benchmark CI label Aug 20, 2023
@adpaco-aws
Copy link
Contributor

Looks like there are regressions on the usual suspects?

@zhassan-aws
Copy link
Contributor

Yeah. I think we should run those locally and check the numbers, because they can just be noise.

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR in favor of #2711.

@celinval celinval closed this Aug 24, 2023
@tautschnig tautschnig deleted the toolchain-2023-08-20 branch November 30, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants