-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mounts on images #995
Mounts on images #995
Conversation
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-c394f4a.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-83ed876.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-792ac90.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-c76e6ef.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-d3f5fa9.modal.run |
Uses a bunch of deprecated defunct functionality but nobody has complained, so we can probably remove and add it back if someone asks for it
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-3ce9e40.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-50ee2db.modal.run |
@@ -23,6 +23,7 @@ | |||
from typing import Any | |||
|
|||
import modal | |||
import modal.container_process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was due to some pyright
warning (not caught by CI)
@prbot approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍. @charlesfrye will follow-up review this.
Nice – seems like a simplification overall |
Removes all explicit usages of
modal.Mount
in favor of adding local files directly on images which will be the recommended syntax going forward (modal.Mount will most likely get deprecation warnings prior to client 1.0)Type of Change
Checklist
lambda-test: false
is added to example frontmatter (---
)modal run
or an alternativecmd
is provided in the example frontmatter (e.g.cmd: ["modal", "deploy"]
)args
are provided in the example frontmatter (e.g.args: ["--prompt", "Formula for room temperature superconductor:"]
latest
python_version
for the base image, if it is used~=x.y.z
or==x.y
version < 1
are pinned to patch version,==0.y.z